warning spew from cddl libnvpair.c

One of our friends working on FBSD is having the above issue. Cross posting in case anyone here is familiar with this issue.


The warning is saying that pctl->nvprt_btwnarrfmt could be anything, which is locally correct. If a stray percent ever makes it into that string, there’ll be a crash at best. I imagine nvprt_btwnarrfmt is pretty well controlled, so it’s probably not an example in practice, but local analysis can’t prove that.

If they don’t like the warning, they can disable it locally with pragmas (_Pragma around that line, perhaps), or just add -Wno-format-security to their warning flags.