whatever happened to this patch?

https://reviews.llvm.org/D62475

It looks like it never got merged, what was the missing step to get this
landed?

Regards,
Andrew

Generally an author should submit an approved patch. If they do not have commit access they should ask someone who does (usually the approver) to commit it on their behalf.

(you generally shouldn’t approve patches if you aren’t in a position to have committed the patch without review if it was your own patch - so at the very least having commit access, but also being sufficiently familiar with the norms of the part of the project that you’re confident committing without review (this doesn’t fully cover all cases, some areas do more cross-review than others, etc))

Thanks David, that makes sense. So:

1. Find someone who has commit access and knowledge about the touched
areas of code.

2. Convince them to review & land the patch.

Yup, that’s the general idea!

you generally shouldn’t approve patches if you aren’t in a position to have committed the patch without review if it was your own patch

I think this might be an overly high bar. Even the most complicated patches need to be approved by somebody. However I think few would argue that the most complicated patches should be committed by anybody without review.

you generally shouldn’t approve patches if you aren’t in a position to have committed the patch without review if it was your own patch

I think this might be an overly high bar. Even the most complicated patches need to be approved by somebody. However I think few would argue that the most complicated patches should be committed by anybody without review.

Certainly - hence the “generally” and the other clauses in that sentence. I’d describe that as sort of “cross-review” - perhaps “reaching consensus”, etc.