80 column limit for .td files

IR & Optimizations
1

Does our coding standard require that .td files fit in 80 columns? I merged [NFC][LLVM] Fix Intrinsics.td to adhere to 80 col limit by jurahul · Pull Request #199346 · llvm/llvm-project yesterday assuming that’s the case, but some questions were raised as to whether the coding standard does really requires it.

If it does not, I guess I should revert the PR above (though I hoped that changes to this file will not cause too many downstream conflicts). If it does, is there a way to add some pre-commit linting to ensure that at-least new changes adhere to this limit?

2

There are no requirements, or ways to verify, for table gen files.

But now that you merged, and it’s innocuous, I would just leave it at that and not revert.

3

Thanks. Are we saying that tablegen files are excluded due to lack of tools? I’d assume just like C++ code, there is desire for some formatting standard for .td files, including column limits so we don’t have too long lines that affect readability.

4

Where was a discussion on clang-formatting TableGen files not long ago: Clang-format and TableGen in LLVM tree

5

PR merged. Clang-format is now disabled on table gen files and coding standards updated to match.

I really thought this was already there…