[Bug 24140] New: Problem with liblldb linking on RHEL 6 and unifying --start-group/--end-group support

Subprojects LLDB
1

Bug ID 24140
Summary Problem with liblldb linking on RHEL 6 and unifying --start-group/–end-group support
Product lldb
Version 3.7
Hardware PC
OS Linux
Status NEW
Severity release blocker
Priority P
Component All Bugs
Assignee lldb-dev@cs.uiuc.edu
Reporter eugene.zelenko@gmail.com
Classification Unclassified

Created attachment 14593 [details]
My patch for this problem

Unfortunately previous patch for liblldb linking on RHEL 6 (bug 24044, r241576)
was not correct because COMPILER_SUPPORTS_GROUPS was local variable in other
function.

I renamed it to LLDB_LINKER_SUPPORTS_GROUPS (--start-group/--end-group is ld
options), made it global and share in cmake/modules/AddLLDB.cmake and
tools/lldb-server/CMakeLists.txt.

I also noticed (with CMake --trace) that it was applied for all LLDB static
libraries. I used PARAM_SHARED to distinguish static libraries and liblldb, but
I'm not sure that this is absolutely correct.

Problem should be fixed in 3.7 and trunk.
2

labath@google.com changed bug 24140

What | Removed | Added |

Comment # 1 on bug 24140 from labath@google.com

The patch looks ok, but I am a bit skeptic about the PARAM_SHARED change. It
seems like a very fragile fragile way to identify a specific library. Is there
any specific problem you are trying to address with this? If it's nothing
serious I would leave that out for now (especially for 3.7 branch). If it's
about optimizing the link time, we can search for another way to achieve this.