[clang-tidy] hasParent for CXXCtorInitializer

Clang Frontend
1

Hi folks,
I was wondering what is the best way to get to the CXXCtroInitializer from child.

In code like this:

struct A {
A() : a(false), c(false) {}
unsigned a : 1;
unsigned c : 3;
};

I am looking for implicit casts from bool.
I added CXXCtorInitializer into hasParent like this:

const internal::ArgumentAdaptingMatcherFunc<
internal::HasParentMatcher,
internal::TypeList<Decl, NestedNameSpecifierLoc, Stmt, TypeLoc, CXXCtorInitializer>,
internal::TypeList<Decl, NestedNameSpecifierLoc, Stmt, TypeLoc>>
LLVM_ATTRIBUTE_UNUSED hasParent = {};

so clang-query doesn’t reject matcher:

implicitCastExpr(hasParent(cxxCtorInitializer()))

but it doesn’t match with anything.

I also tried something like this:

auto matcher = hasAncestor(cxxConstructorDecl(hasAnyConstructorInitializer(
cxxCtorInitializer(forField(isOneBitBitField()),
withInitializer(implicitCastExpr(equalsBoundNode(“cast”)))
))));

and then
implicitCastExpr(matcher).bind(“cast”)

but it doesn’t seems to work either.
Any thoughts?

Piotr

2

Manuel, do you have an idea what could be wrong here?

3

+sam and benjamin

Manuel, do you have an idea what could be wrong here?

Generally, I’d expect this to happen if the CXXCtorInitializer is not in the parent map. A patch with a failing test might help to see the problem.

4

+sam and benjamin

Manuel, do you have an idea what could be wrong here?

Generally, I'd expect this to happen if the CXXCtorInitializer is not in
the parent map. A patch with a failing test might help to see the problem.

But I wouldn't expect that the second matcher that uses hasAncestor doesn't
work either.
I will generate the patch for the second matcher tomorrow.