LLVM 7.1.0 release - Please test the branch

Project Infrastructure Release Testers
1

Hi,

The release_70 branch is ready for the 7.1.0 release. I have updated the
version and pushed a fix for https://bugs.llvm.org/show_bug.cgi?id=39427,
which is the only bug we will be fixing in this release.

Since this is an ABI breaking changing and also we are introducing a
minor version for the first time, please take some time to test the
branch and make sure everything works as expected. I'm going
to try to do the 7.1.0-rc1 release some time after 8.0.0-rc2, once the
activity around the release calms down a little.

Thanks,
Tom

2

The SOVERSION is still '7'. Maybe we should force it to '7.1' here?

3

It should already be changed. This is what I get when I build:

[tstellar@llvm llvm-build]$ objdump -p lib/libLLVM-7.1.so | grep SONAME
  SONAME libLLVM-7.1.so

-Tom

4

I'm talking about SOVERSION of shared libs from BUILD_SHARED_LIBS=ON.
The one defined in llvm_add_library() function:

      set_target_properties(${name}
        PROPERTIES
        # Since 4.0.0, the ABI version is indicated by the major version
        SOVERSION ${LLVM_VERSION_MAJOR}${LLVM_VERSION_SUFFIX}
        VERSION ${LLVM_VERSION_MAJOR}${LLVM_VERSION_SUFFIX})

5

Ok, I see. You are correct, we should change the soname on those. I can
fix this.

-Tom

6

Hi,

The release_70 branch is ready for the 7.1.0 release. I have updated the
version and pushed a fix for 39427 – gcc ABI incompatibility when passing llvm::Optional,
which is the only bug we will be fixing in this release.

Since this is an ABI breaking changing and also we are introducing a
minor version for the first time, please take some time to test the
branch and make sure everything works as expected. I'm going
to try to do the 7.1.0-rc1 release some time after 8.0.0-rc2, once the
activity around the release calms down a little.

The SOVERSION is still '7'. Maybe we should force it to '7.1' here?

It should already be changed. This is what I get when I build:

[tstellar@llvm llvm-build]$ objdump -p lib/libLLVM-7.1.so | grep SONAME
  SONAME libLLVM-7.1.so

I'm talking about SOVERSION of shared libs from BUILD_SHARED_LIBS=ON.
The one defined in llvm_add_library() function:

      set_target_properties(${name}
        PROPERTIES
        # Since 4.0.0, the ABI version is indicated by the major version
        SOVERSION ${LLVM_VERSION_MAJOR}${LLVM_VERSION_SUFFIX}
        VERSION ${LLVM_VERSION_MAJOR}${LLVM_VERSION_SUFFIX})

Ok, I see. You are correct, we should change the soname on those. I can
fix this.

This should be fixed now by r353247, can you re-test?

-Tom

7

Yes, though I don't think returning to '71' is a good idea. It
introduces a value that is technically larger than '8', and people
running ldconfig(1) will get libs relinked to .so.71 all the time.
Putting a dot there should be safer.

8

Testing on Windows looks okay.

9

This is fixed now in r353348. Can you test again?

-Tom

10

You forgot to update VERSION as well.

11

This should be fixed now in r353565. Let me know if there are any other issues.

-Tom

12

Thanks, looks good now.