make test: rewriter tests failing

Is anyone else seeing this?

$ make test
--- Running clang tests ---
..
---- Rewriter/ivar-encoding-2.cpp failed ----
..
---- Rewriter/metadata-test-1.cpp failed ----
..........
---- Rewriter/objc-string-concat-1.cpp failed ----
....
---- Rewriter/objc-synchronized-1.cpp failed ----
......
---- Rewriter/rewrite-foreach-1.cpp failed ----
..
---- Rewriter/rewrite-foreach-2.cpp failed ----
..
---- Rewriter/rewrite-foreach-3.cpp failed ----
..
---- Rewriter/rewrite-foreach-4.cpp failed ----
..
---- Rewriter/rewrite-foreach-5.cpp failed ----
..
---- Rewriter/rewrite-foreach-6.cpp failed ----
....
---- Rewriter/rewrite-try-catch.cpp failed ----
....
---- Rewriter/undecl-objc-h.cpp failed ----
....
---- Rewriter/undef-field-reference-1.cpp failed ----
...

Is anyone else seeing this?

Yes. I just sent Chris the email below…

snaroff

Is anyone else seeing this?

Yes. I just sent Chris the email below…

Ah yeah, this is probably me. The problem is that the rewriter now obeys -o, and if you leave it out, it defaults to “inputfilename.cpp” as the output. The fix is to change the tests to use “-o -” on the run lines. I’ll take care of this in an hour or so if noone beats me to it,

-chris

I just took care of it (before seeing your response).

I figured this was what you wanted:-)

snaroff