[Patch] Check support for 'p' packet

Subprojects LLDB
#1

Hi All,
Continuing with my efforts to make lddb work with gdbserver, I observed that lldb was always using 'p' packet for registers while gdbserver does not support it. So I have added code to check for support of this packet. If this is not available then we use 'g' packet. Tested with gdbserver and it worked ok. Also connected it with a modified qemu stub to make sure that 'p' packet availability check works fine. Ok to commit?

Regards,
Abid

p_packet.patch (3.34 KB)

#2

Yes, OK to submit after you modify:

GDBRemoteCommunicationClient::ResetDiscoverableSettings()

to reset the new m_supports_p the calculate enum in the above function.

Greg

#3

Greg,
Thanks for review. Committed after making the suggested change.

Regards,
Abid