[PATCH] Obsolete WebKit Calling Convention

Project Infrastructure LLVM Dev List Archives
1

Hi @ll,

I would like to obsolete and completely remove the WebKit Calling Convention. The CC was originally added for FTL and there are no other users I am aware off. Since WebKit moved away from LLVM a while ago I don’t see the need to keep the dead code around anymore.

Please let me know if anyone happens to use this calling convention or has any objection with removing it.

Thanks

Cheers,
Juergen

0001-Obsolete-WebKit-Calling-Convention.patch (32.9 KB)

2

Makes sense to me.

Watch out for the binary bitcode compatibility files for 3.{6,7,8}. We should
be able to rewrite 'webkit_jscc' to 'cc<n>', and should update the calling
convention enums to make sure that that <n> isn't reused.

vedant

3

Makes sense to me.

I am not aware of any webkit calling convention users either.

Watch out for the binary bitcode compatibility files for 3.{6,7,8}. We should
be able to rewrite 'webkit_jscc' to 'cc<n>', and should update the calling
convention enums to make sure that that <n> isn't reused.

If possible I'd rather abort with an error message than rewriting to the wrong calling convention.

- Matthias

4

SGTM.

-eric

5

SGTM