PostDominatorTree methods and non-constness of arguments

Project Infrastructure LLVM Dev List Archives
1

Hello,

I was looking at the PostDominatorTree member functions and I noticed that some of them are not const or don't have const parameters for no apparent (to me) valid reason.

Like for example "properlyDominates" or getNode() that seems to only do a lookup in a table using the passed BB as a key.
In addition to that findNearestCommonDominator is not set as const while doesn't seem to be doing any change to the Dominator object itself.

Is there any reason I'm missing for it being like that?

Cheers,
Marcello

2

Sometimes const is just left off even when it could go on - feel free
to submit a patch constifying things if they can be made const. :slight_smile:

-eric