Proposal
I would like to propose that we use github issues for requesting commit access rather than having new users email @clattner . Additionally, I propose that any LLVM admin can approve commit access and not just @clattner
Why
This new process will eliminate the single point of failure that we have with the current "email @clattner " process. This will help improve the experience for new users and ensure that commit access requests are handled in a timely matter even when @clattner is unavailable.
Additionally, this will help make the process more transparent, so the entire community can see who is requesting commit access and provide feedback. It also makes it easier to query who has recently requested commit access, so that they can be excluded from the monthly audit for users that don’t meet our criteria for retaining commit access.
Out Of Scope
This proposal will not change the criteria used for granting commit access. We will use the same criteria described here. (i.e. Anyone who follows the instructions for requesting commit access will be granted access).
I know we’ve discussed changing this in the past, but any changes will need to be proposed in a separate RFC.
How
We will add to the developer policy a link for a pre-populated issue that can be used for requesting commit access. We will use our existing issue labeler to match the ‘Request Commit Access’ string in the title and add the ‘infrastructure:commit-access-request’ label. This will notify everyone on the infrastructure-commit-access-request team (which will contain only LLVM admins) of this new request. Once the request is made, one of the admins will send the user an invite to join the LLVM Committers team.
GitHub also has a template feature, which allows you to create predefined templates for issues that will automatically add labels and assignees. We could use this instead, however, I think this would regress the experience for everyone filing issues, because once you add a template, the new issue page will show you a list of templates rather than taking you to a blank issue form, and I think the template list can be confusing and hard to follow, especially for new users.
Conclusion
Thanks for reading, let me know what you think.
