RFC: Commit Access Criteria

[DavidSpickett]

@jplehr

I wonder if we can / should have some sort of labeler action that marks a PR to be submitted by the reviewer as this was not always obvious to me in the past and not every new contributor may let the reviewer know that they do not have commit access.

I tried to do this by using the review approved event, long story short, that event has read only permissions so it can’t change anything (RFC / FYI: Pull Request Greetings For New Contributors - #18 by DavidSpickett, Revert "[GitHub][workflows] Ask reviewers to merge PRs when author cannot" by DavidSpickett · Pull Request #81722 · llvm/llvm-project · GitHub).

Adding a label or comment when the PR is opened is an alternative. We already do this for other purposes, and some of the code in that reverted PR could be re-used.

I lean toward a label, since it’s always visible in the UI and you could search label:reviewer-merge and state:approved to find anything pending.