RFC / FYI: Pull Request Greetings For New Contributors

DavidSpickett · February 5, 2024, 10:59am

[GitHub][workflows] Ask reviewers to merge new contributor's PRs

llvm:main ← DavidSpickett:new-user-approved

opened 10:54AM - 05 Feb 24 UTC

As suggested on an RFC for previous changes in this area - https://discourse.llv…m.org/t/rfc-fyi-pull-request-greetings-for-new-contributors/75458/12. This is based on GitHub's example for this use case: https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#running-a-workflow-when-a-pull-request-is-approved When a review is submitted we check: * If it's an approval. * Whether it's on a PR from a new contributor (using the same logic as `new-prs.yml`). Then if we haven't already left a comment, add one to tell the author that they can have the PR merged by a reviewer. PRs can get multiple approvals, so we'll look for another magic HTML comment to tell if we've already done this. The comment doesn't ask the reviewers to merge it right away, just on the chance that the author still had things to do. As we don't have a norm of merging as soon as there is an approval, so doing that without asking might be surprising. It also notes that if we need multiple approvals to wait for those. Though in that situation I don't think GitHub will enable the merge button until they've all approved anyway. In future we can make this check more clever, perhaps by using a GitHub API to check all users and see if they have permissions. It's limited to new contributor PRs for now since we know for sure they won't have permissions. With this change, new contributor PRs will get: * A welcome comment on submission. * This merge on behalf comment on first approval. * A post merge comment about what to expect from the build bots.

Only applies to new contributors right now but we can generalise it later.

Topic		Replies	Views
RFC: Encouraging Reviewers to Merge on Behalf of PR Authors without commit access LLVM Project	19	1103	January 30, 2025
Code Review Process Update LLVM Project	131	10234	February 3, 2024
Enable Contributions Through Pull-request For LLVM LLVM Dev List Archives	59	1809	November 14, 2019
[RFC] Mention our AI policy in the greeting message for first-time contributors Community	9	421	April 27, 2026
Revisiting commit-access criteria (2026) LLVM Project	54	2005	July 7, 2026

RFC / FYI: Pull Request Greetings For New Contributors

Related topics