As part of a little tidy-up I’ve been doing (see [mlir][vector] Use `DenseI64ArrayAttr` for constant_mask dim sizes by MacDue · Pull Request #100997 · llvm/llvm-project · GitHub ), I took a look at vector.reshape. This operation was added five years ago and has no lowerings or uses within upstream M…

I’ve grepped the IREE code base and haven’t found any uses either. So +1 to dropping it.

Local search yielded no usage from Intel side. +1 from us.

I’ve made a PR for removal here: [mlir][vector] Remove `vector.reshape` operation by MacDue · Pull Request #101645 · llvm/llvm-project · GitHub

As a related idea, sometime later vector.shape_cast could be renamed to vector.reshape, which could be a more accurate name (as shape_casts are not necessarily cast, they can lower to data movement).

Forgot to hit send earlier: no usage Google side either.

I’d avoid too many renames in one go. Let this one sink, and if no downstream is affected, we talk about the next one. Renaming is more complicated than removing an unused op. Unless of course, the renamed op is also unused. But I’d not cross wires as a general strategy.

Of course :+1: I don’t intend to rename shape_cast with this change (or soon after it). It just occurred to me that if “vector.reshape” was free, it may be a more fitting name for what vector.shape_cast has evolved into.

I’ve landed the removal now (though I don’t object to a revert if someone wants to save the operation :slight_smile:). Also, I have a patch to add a notice to Deprecations & Current Refactoring - MLIR here: Add notice about the removal of `vector.reshape` by MacDue · Pull Request #198 · llvm/mlir-w…

[RFC] Should `vector.reshape` be removed?

MLIR

dcaballe July 31, 2024, 11:19pm 3

Thanks for the cleanup! +1 to remove it.

Topic		Replies	Views
[RFC] Reshape Ops Restructuring MLIR	6	1894	May 6, 2021
Improving handling of unit dimensions in the vector dialect MLIR	29	1437	December 14, 2023
[RFC, mlir, vector] Deprecate then remove `vector.splat` MLIR mlir	8	577	October 7, 2025
Failed to legalize operation 'tensor.reshape' MLIR	2	301	February 24, 2022
[RFC] Changing interface of tensor/memref.reshape op MLIR	2	349	December 21, 2022

[RFC] Should `vector.reshape` be removed?

Related topics