Deprecation: OpBuilder<"signature"> ODS form, use OpBuilderDAG instead

MLIR
1

This is a deprecation notice for ODS syntax utilized to define custom builders. The old syntax,

OpBuilder<"signature", [{ body }]>

is deprecated since [mlir] use OpBuilderDAG instead of OpBuilder · llvm/llvm-project@89eab30 · GitHub and will be removed in a ~month.

Please use the new syntax, consistent with other method declarations in ODS,

OpBuilderDAG<(ins "Type":$name, CArg<"Type", "default value">:$name), [{ body }]>

I updated all in-tree uses and updated the documentation. A tool is available to automate the migration process.

2

Really great work Alex, thanks for pushing this!

3

+1! Looks awesome. Thanks Alex! :smiley:

4

The deprecated format was removed in [mlir] remove deprecated string-based OpBuilder from ODS · llvm/llvm-project@2f5569f · GitHub. As a next stage, I will rename OpBuilderDAG to OpBuilder.

5

Thank you again for doing this Alex!