https://reviews.llvm.org/D23393

Hey folks,

I'm new here, wasn't expecting to subscribe but here I am. The reason I'm here is that I came across a doc bug, I spent quite a bit of time learning all the tips and tricks for submitting patches to llvm including using phabricator and finally tweeting at the llvm account to get some attention.

The patch is here:
https://reviews.llvm.org/D23393

I looked in git and it doesn't look like this was pulled in. Has it been accepted? If no, did I miss some step?

Thanks,
-Alfred

http://llvm.org/viewvc/llvm-project?rev=281297&view=rev

Thanks Davide!!

-Alfred

This is exactly why we should switch to github. It is much easier for new contributors to start with small fixes.

+1, would be nice, that was a LOT of work, of which 80%+ felt unnecessary. I think LLVM is GREAT and really amazing, however quite frankly, although I enjoy contributing to open source, this experience made me more likely to search out projects which a lower bar to entry and I likely will not bother to contribute fixes unless they were critical due to this barrier.

-Alfred

There are two really quite separate issues here:
1) Patches, even trivial ones can sit unreviewed for long periods of
time leading to a negative first time contribution experience.
2) Arguably, Phabricator provides a confusing interface for first-time
or irregular users. There are efforts to improve this
https://secure.phabricator.com/T5000

As for 1), this is something a few of us discussed at the LLVM
Cauldron in Hebden Bridge last week which inspired me to give a
lightning talk. Slides:
<https://speakerdeck.com/asb/can-we-improve-the-experience-of-first-time-llvm-contributors&gt;
Video: <Can we improve the experience of first-time LLVM contributors? - LLVM Cauldron 2016 - YouTube; I'm intending to
start an RFC thread when I get a chance. The tl;dr is I propose
stealing Rust's highfive-bot and forming a team of eager volunteers
who want to help improve response times for patches from first-time
contributors.

Best,

Alex

I don’t think it’s fair to say that the Phabricator interface is confusing for first-time or irregular users. I use Phabricator on a couple of projects and review things with it quite regularly and I still find the interface obtuse.

David

+1, I'm a freebsd guy as well, we (freebsd) unfortunately use phabricator as well, it's just suboptimal.

+2. I use Phab since it was introduced to LLVM and I haven't "got
used" to it at all. Same with Gerrit.

GitHub, on the other hand, took me 10 minutes to get used to and 20 to
use it well. 30 minutes to find bugs, 40 to report them and a day or
two to get them fixed.

Though, with current GitHub proposals, pull requests may not work
well. We'll have to think a bit more on how that would work...

--renato

From: llvm-dev [mailto:llvm-dev-bounces@lists.llvm.org] On Behalf Of
Renato Golin via llvm-dev
Sent: Tuesday, September 13, 2016 1:47 AM
To: Alfred Perlstein
Cc: llvm-dev
Subject: Re: [llvm-dev] https://reviews.llvm.org/D23393

>> I don’t think it’s fair to say that the Phabricator interface is
confusing
>> for first-time or irregular users. I use Phabricator on a couple of
>> projects and review things with it quite regularly and I still find the
>> interface obtuse.
>>
> +1, I'm a freebsd guy as well, we (freebsd) unfortunately use
phabricator as
> well, it's just suboptimal.

+2. I use Phab since it was introduced to LLVM and I haven't "got
used" to it at all.

Oooh, a "dump on Phab" thread! Sign me up...

There's really no good reason why we should have to have detailed cookbook
instructions on how to use Phab (http://llvm.org/docs/Phabricator.html).
Phab's help should be used in UI design classes everywhere as an example
of how NOT to do it.
--paulr