Hi all, I’m looking for some general thoughts from the community about something that has recently happened. To be clear, I do not believe anybody has done anything maliciously or anything, but I do think it would be helpful for people to be on the same page as to what is/is not appropriate, in the view of the community.
I’ve been involved with reviewing https://github.com/llvm/llvm-project/pull/157499, authored by @Prabhuk and with @ilovepi having reviewed and approved much earlier in the process. @ilovepi asked me to review the patch before it landed, which I duly did and marked it with “request changes” so that it was clear the PR wasn’t in a sufficient state to land it at the time. We continued with back and forth reviews and updates up until mid December when I went away on my Christmas break. I didn’t get back until the start of this week and have been trying to catch up on a large email and review backlog in the meantime.
@Prabhuk addressed my most recent round of comments not long after I finished work for the calendar year, then pinged a couple of days later (aside, not the usual week period that is recommended). A week ago, they then, with no further input from anybody, posted a comment saying they’d merge the PR soon, because it was blocking downstream work. They merged the PR about a day later. In doing so, they stated they’d be happy to revert etc post landing, if I came back and had any further concerns.
My main concerns here are twofold:
- Although @ilovepi approved the PR a while back, it had changed a fair bit since the original approval, so I think it could be argued that this PR was effectively landed without explicit approval, especially as I had clearly raised concerns after this approval.
- The idea of saying “I’m going to merge this due to a lack of response and it’s blocking me” is a bit of a dangerous idea and seems to fall afoul of our guidelines here.
Are my concerns legitimate, or am I viewing things from the wrong way?
What I think could have been done better:
- I could have communicated my expected absence period over the Christmas break on the review.
- @Prabhuk could have sought review from another developer, e.g. @ilovepi to confirm that all my points had been addressed.
- A specific note of a need to get the change landed might have prompted me to suggest whether another reviewer could finish things off in my absence.