[MLIR] Why ToSaToLinalg not convert tosa::AddOp to linalg::AddOp

MLS · May 14, 2024, 3:42am

llvm/llvm-project/blob/7198c3d613f1087c78124928cbe2cbc4e03a0e5a/mlir/lib/Conversion/TosaToLinalg/TosaToLinalg.cpp#L2554-L2571


      
          void mlir::tosa::populateTosaToLinalgConversionPatterns(
              RewritePatternSet *patterns) {
          
            // We have multiple resize coverters to handle degenerate cases.
            patterns->add<GenericResizeConverter>(patterns->getContext(),
                                                  /*benefit=*/100);
            patterns->add<ResizeUnaryConverter>(patterns->getContext(),
                                                /*benefit=*/200);
            patterns->add<MaterializeResizeBroadcast>(patterns->getContext(),
                                                      /*benefit=*/300);
          
            patterns->add<
                // clang-format off
                PointwiseConverter<tosa::AddOp>,
                PointwiseConverter<tosa::SubOp>,
                PointwiseConverter<tosa::MulOp>,
                PointwiseConverter<tosa::IntDivOp>,
                PointwiseConverter<tosa::NegateOp>,

I would like to know why ToSaToLinalg does not convert tosa::AddOp to linalg::Add, but to linalg.generic

rengolin · May 14, 2024, 10:37am

Because linalg::AddOp is new and TOSA has added lowering to Linalg a long time ago.

Since linalg::AddOp has strict cast semantics, TOSA would have to lower to not just AddOp but also potentially broadcasts, reduction and types cast operations. Same for all other unary/binary/ternary named ops added recently.

I’d be happy to work with TOSA folks to add that support to their lowering, but as mentioned in a torch-mlir thread, if we want to make this into an option, then we may have to duplicate code.

MLS · May 14, 2024, 1:00pm

Got it, thank you!

Topic		Replies	Views
Conversion from Tosa to Linalg TOSA	8	233	April 29, 2024
[Tosa][tosa-to-linalg] Code design problem of Tosa to Linalg conversion MLIR	6	511	November 30, 2022
[TOSA][TosaToLinalg] Is it necessary to fold broadcast dims when convert to Linalg? MLIR	5	493	October 5, 2022
Quantized Tosa IR lowing to llvm IR MLIR	12	617	November 29, 2023
How to lower linalg.generic to affine loops MLIR	1	581	January 31, 2023

[MLIR] Why ToSaToLinalg not convert tosa::AddOp to linalg::AddOp

Related Topics