Reviews.llvm.org read-only mode

[mehdi_amini]

@MaskRay

• Allow user registration? No.

Why not? It’s useful for people to be able to ping on a revision.

@MaskRay

• Allow new differentials? Currently yes, but should be no at some point. There is currently a red banner to discourage new differentials (Update on GitHub pull requests - #76 by MaskRay) Can someone figure out how to patch src/applications/differential/conduit/DifferentialConduitAPIMethod.php to forbid new differentials?

I was looking at this earlier, something simple like this may be enough but I don’t have a way to test it right now of course:

diff --git a/src/applications/differential/editor/DifferentialRevisionEditEngine.php b/src/applications/differential/editor/DifferentialRevisionEditEngine.php
index 74fee8221956..836e25fe51eb 100644
--- a/src/applications/differential/editor/DifferentialRevisionEditEngine.php
+++ b/src/applications/differential/editor/DifferentialRevisionEditEngine.php
@@ -128,6 +128,10 @@ final class DifferentialRevisionEditEngine
     }
 
     $is_create = $this->getIsCreate();
+    if ($is_create) {
+      throw new Exception('New revision creation is disabled, please use GitHub Pull-Requests.');
+    }
+
     $is_update = ($diff && !$is_create);
 
     $fields = array();

@MaskRay

• Allow updating existing differentials? Currently yes, but should be no at some point (Oct 1?)

I would look into some data-driven approach: after we stop accepting new revision, we should be able to know how many revision are still updated every day/week and take it from there!