Sign up to phab, authorize 'r4nt'?

A colleague just went to sign up to llvm reviews using a github account. From https:/reviews.llvm.org/login/?next= which looks normal, goes to a page saying:

Authorize LLVM Reviews
LLVM Reviews by r4nt
wants to access your $username account

Green button saying Authorize r4nt

So, who’s r4nt, and is this expected behaviour?

Cheers

r4nt is the github username of +Manuel Klimek, who I’m guessing set up the integration

Hi,

GitHub allows to “transfer ownership” for such applications, we should likely transfer this to the LLVM account ideally. I don’t know who can coordinate this with Manuel, maybe Tom or Mike?

Hi,

GitHub allows to "transfer ownership" for such applications, we should likely transfer this to the LLVM account ideally. I don't know who can coordinate this with Manuel, maybe Tom or Mike?

Is phabricator actually using r4nt's github account or is
r4nt just part of the description of our phabricator instance?

-Tom

The oAuth application is owned by r4nt’s GitHub account I believe: https://docs.github.com/en/developers/apps/authorizing-oauth-apps

Phab does not reference r4nt, it just has the token for the oAuth application. When a user wants to login on Phab for the first time, they are redirected to GitHub itself to “grant permission” to r4nt to log them in on Phab (this is the message in the original email in this thread).

     > Hi,
     >
     > GitHub allows to "transfer ownership" for such applications, we should likely transfer this to the LLVM account ideally. I don't know who can coordinate this with Manuel, maybe Tom or Mike?
     >

    Is phabricator actually using r4nt's github account or is
    r4nt just part of the description of our phabricator instance?

The oAuth application is owned by r4nt's GitHub account I believe: Authorizing OAuth Apps - GitHub Docs

Phab does not reference r4nt, it just has the token for the oAuth application. When a user wants to login on Phab for the first time, they are redirected to GitHub itself to "grant permission" to r4nt to log them in on Phab (this is the message in the original email in this thread).

OK, that make sense. Where is the OAuth app phabricator is using?
Is it on GitHub somewhere? I don't see anything in r4nt's repositories
that looks like an OAuth app.

-Tom

This isn’t public like a repo, each user can manage their own in https://github.com/settings/developers

     >
     > > Hi,
     > >
     > > GitHub allows to "transfer ownership" for such applications, we should likely transfer this to the LLVM account ideally. I don't know who can coordinate this with Manuel, maybe Tom or Mike?
     > >
     >
     > Is phabricator actually using r4nt's github account or is
     > r4nt just part of the description of our phabricator instance?
     >
     > The oAuth application is owned by r4nt's GitHub account I believe: Authorizing OAuth Apps - GitHub Docs <https://docs.github.com/en/developers/apps/authorizing-oauth-apps&gt;
     >
     > Phab does not reference r4nt, it just has the token for the oAuth application. When a user wants to login on Phab for the first time, they are redirected to GitHub itself to "grant permission" to r4nt to log them in on Phab (this is the message in the original email in this thread).
     >

    OK, that make sense. Where is the OAuth app phabricator is using?
    Is it on GitHub somewhere? I don't see anything in r4nt's repositories
    that looks like an OAuth app.

This isn't public like a repo, each user can manage their own in Sign in to GitHub · GitHub

Ok, I'll try to coordinate this with Manuel.

-Tom

I think any user with admin access and LLVM github access can go into phab’s “Auth” app, and edit the github auth provider with a new App ID and secret, right?

Yes, but that would require everyone to re-authorize the new application on GitHub, while if you transfer the application on GitHub side, it’ll become part of the LLVM organization with the existing token and (I think) it will “keep the lights on”.

I think any user with admin access and LLVM github access can go into phab’s “Auth” app, and edit the github auth provider with a new App ID and secret, right?

Yes, but that would require everyone to re-authorize the new application on GitHub, while if you transfer the application on GitHub side, it’ll become part of the LLVM organization with the existing token and (I think) it will “keep the lights on”.

Oooh, cool, wasn’t aware that works. Tom, do you want to set up a meeting for us? What time works for you? (I’m CEST)

        I think any user with admin access and LLVM github access can go into phab's "Auth" app, and edit the github auth provider with a new App ID and secret, right?

    Yes, but that would require everyone to re-authorize the new application on GitHub, while if you transfer the application on GitHub side, it'll become part of the LLVM organization with the existing token and (I think) it will "keep the lights on".

Oooh, cool, wasn't aware that works. Tom, do you want to set up a meeting for us? What time works for you? (I'm CEST)

Does 4:30 PM CEST tomorrow work for you?

-Tom