Unresolved issues from the LLVM 15.x release

Hi!

With the LLVM 15.x release wrapping up there are some issues that came up and were discussed during the release process that still don’t have a good solution. I have collected these issues and present them here now so that we have time to address them during the LLVM 16 development window:

libclang SOVERSION handling

One of the hotter debates right before the LLVM 15 window closed was how to handle libclang versioning. This was mostly discussed in this thread here that was opened by @h-vetinari. The compromise that was adopted in LLVM 15 was to make this configurable in CMake with the understanding that we should probably make a better-anchored decision before LLVM 16.

non-POD ABI

This commit was reverted in both LLVM 14 and 15 because it was not exactly clear how to handle this. @dblaikie was driving this discussion in this issue

Several runtime build issues

In LLVM 14 we switched to use runtime builds for our test script. This was reverted because check-all didn’t run the tests for the runtimes. This was fixed for LLVM 15, but later reverted on main. This discussion can be found on Phabricator here. - I think this just needs a fix from @petrhosek

Spinning out from runtime builds were also the discussion about the harmonization of triples and search paths and also my discussion about removing the legacy path. @rovka @tamas and @petrhosek are most involved here.

A reminder here for @hansw2000 to enable Runtime builds for windows.

implicit-function-declaration error breaks configure scripts

LLVM 15.x initially shipped with the warning implicit-function-declaration made an error. This was reported that it broke several configure scripts in some almost invisible ways. This discussion was brought up by @mgorny and @AaronBallman

Call to action

I hope we can resurrect these threads or have an active discussion about the issues above and have them sorted out before we branch out LLVM 16.x

I might also very well have forgotten some issues - please use this thread to bring up those discussions as well.

4 Likes

We’re making some progress on that now, luckily. ⚙ D119051 Extend the C++03 definition of POD to include defaulted functions

2 Likes

I think another key issue with this release is the handling of the top-level cmake directory. We have received many, many, many issue reports because pretty much all subprojects depend on these cmake files now, but they are not part of the individual subproject tarballs.

The current situation is quite hostile to anyone who tries to build LLVM from the distributed tarballs and does not happen to be an expert in LLVM packaging idiosyncrasies. For the next release, we should probably go back to the scheme where the cmake directory is included in individual tarballs, to make LLVM builds “just work” again.

1 Like

Good memory. Yes this should be fixed. I can do it if you can file a GitHub issue and assign it to me.

This was the result of many discussions in the LLVM 13/14 timeframe (including cmake changes the folder hierarchy in the subproject tarballs, which also breaks a lot of projects).

I don’t think there’s a good solution to subproject-tarballs while also having common cmake infrastructure.

libcxx has moved away from standalone builds completely AFAIU, for example.

One thing we haven’t tried yet (but I’m pretty sure it’s not a good idea, just spitballing) is to have each subproject have it’s own cmake infra that’s just a symlink to the project-level cmake folder. Those symlinks could be materialised for the tarball generation so the the subproject tarballs are more easily usable again.

The important case here: consider downstream project that requires llvm only (no other components, for example custom language frontend and some custom backend). With LLVM 15 it cannot just fetch llvm subdir and add necessary things on top / inside.

AFAIU all that’s necessary is fetching both the llvm & the cmake tarballs and unpacking them in the same folder, then build the llvm folder.

I’m not talking about fetching tarballs, but rather about importing llvm (via e.g. git subtree) into downstream repo. The top-level cmake folder should be imported as well and it might be in quite strange place.

Haven’t used git subtree, but I can’t see why it wouldn’t be possible to do that twice (all that should be necessary is putting llvm/ and cmake/ in the same folder)?

For what it’s worth, in Chromium we’re still struggling with test failures after D132438 relanded. I’m not sure why these problems aren’t being caught upstream.

Thanks, will do.

15.0.1 and up have downgraded this back into an on-by-default warning (rather than a warning that defaults to an error), so for 15.x, I think we’re good.

For 16.x, the current behavior is that they are warnings which default to an error. My understanding is that @mgorny and others have been diligently working through the fallout and have been making good progress on fixing up things from their side. So I’m relying on distro folks to speak up if we’re still not in a good enough place to be able to leave the diagnostics as defaulting to an error, but I figured we’d see where things stand as we get closer to the branch point for 16.0.0.

It doesn’t work. Left a comment in Should buildbots switch to ENABLE_RUNTIMES instead of ENABLE_PROJECTS for compiler-rt? - #10 by hansw2000

Bumping this topic again so we have a less “hair-on-fire” situation when dealing with this than last time. :sweat_smile:

My preference would be to default to have a separate SOVERSION for libclang that only changes when actually necessary, along the lines of the original RFC.

This would however represent the third(!) change of default in as many LLVM releases, and I can understand that people would be reluctant to do so (though I noted already for the reversion of the default for LLVM 15 that we’d find ourselves in this situation…)

LLVM version libclang SOVERSION Comment
13 13 and before, situation pre-RFC
14 13 RFC accepted
15 15 Default reverted to pre-RFC; switch available to keep RFC
16 ? Re-apply RFC?

The reason I left a question-mark in the table is that I think a deficiency of the original approach was to use a numbering scheme which made it look like a bug (i.e. someone forgot to bump 13->14). I think if there were a separate libclang versioning scheme that looks less like it should be 1:1 with the LLVM version (whether that’s restarting from 1, adding 1000 to LLVM version[1], or whatever), this would help get rid of the confusion with a separate SOVERSION, and would still let people that are affected by ABI benefit from the fact that there’s now less things to rebuild.


  1. those that change the libclang ABI; the idea of the RFC was to reset the libclang SOVERSION to the current LLVM version whenever the ABI changes, meaning we’d continually run into the “looks like someone forgot to bump the version” issue. ↩︎