[Zorg] Simplify ClangBuilder

Hi Richard, Marco,

I noticed that you two are the remaining bot owners using the
`getClangBuildFactory` from `ClangBuilder`. All the other bots using
that builder have moved to the new `getClangCMakeBuildFactory`,
including Windows ones.

Given that they do similar functionalities, I'd like to encourage you
to move to the new factory, so that we can simplify the builder's
code.

Thanks!
--renato

PS: The builders are:

Richard:
http://lab.llvm.org:8011/builders/clang-x86_64-linux-selfhost-modules-2
http://lab.llvm.org:8011/builders/clang-x86_64-linux-selfhost-modules

Marco:
http://lab.llvm.org:8011/builders/clang-bpf-build

Renato,
thanks for the heads-up.

For clang-bpf-build the change should be trivial since we don't use a
fancy configuration.
I have attached the patch, please apply if appropriate.

Thanks.

Regards,

Marco Leogrande

inaccuracies, logical fallacies and repetitions.

0001-zorg-bpf-Convert-builder-to-use-getClangCMakeBuildFa.patch (1.42 KB)

I believe it should just work. Galina, can you give it a try?

The build should "just work". :slight_smile:

thanks!
--renato

I applied it and reconfigured the master.

Thanks for the heads-up!

Thanks

Galina

Thanks Galina!

Marco, the build is complaining about Ninja:

http://lab.llvm.org:8011/builders/clang-bpf-build/builds/414/steps/cmake%20stage%201/logs/stdio

CMake was unable to find a build program corresponding to "Ninja"

Now I remember we used ninja by default because it's easier on Windows
(than make).

Can you install ninja on that machine?

$ sudo apt-get install ninja-build

should be enough. Sorry for that!

--renato

I have installed ninja and retriggered that build.
I will monitor the results to confirm it succeeds.

Regards,

Marco Leogrande

inaccuracies, logical fallacies and repetitions.

It’s alive! :slight_smile: