Can't access https://reviews.llvm.org/

Project Infrastructure
1

Hi
these days, can;t access https://reviews.llvm.org/, if hope to review the past patch, have any other method? such as want to access https://reviews.llvm.org/D364xx, thanks.

2

You can replace https://reviews.llvm.org/ with http://108.170.204.19/, which is the static mirror for the Phabricator instance.

The DNS records haven’t been updated yet, as nobody with the necessary permissions could be reached.

cc @MaskRay

3 Likes
3

now it is okay, Merry X’mas.

4

Not currently working for me but the workaround posted does work.

5

We need someone who can change DNS to redirect reviews.llvm.org to http://108.170.204.19/ . I’ll then create a HTTPS certificate.

6

I have updated, but will take awhile to propagate.

7

MaskRay created a cert and updated his web server.

8

To be clear: at this time, authors of patches on reviews.llvm.org which have not merged yet, should re-submit their patches as a Github PR? (Thus far they have been discouraged from doing so to avoid splitting the context of the review in two places.)

If so, could this be announced in a dedicated thread?

9

I am the author of a larger approved patch that is still on reviews.llvm.org that I would like to push this week. I also would like very much not to have to re-submit it as a PR.

10

I think yes, people should be making github PRs from phabricator reviews. And we should’ve already made that announcement after emails stopped being sent a month ago.

If you change has already gotten comments on phab, I’d leave a link to that the former phab review in the github PR, and ask the same people to approve the github PR.

11

Thanks for restoring read-only access to Phab again!

At libc++ we still have quite a number of patches that are “maybe useful and abandoned by the author”. I still would like to be able to assess their status. We most definitely can move them to GH if they are useful. So having a working Phab is still important to find these patches. I expect libc++ is not the only one with such patches.

12

I was mainly thinking of patches that aren’t approved yet. If a patch is approved, and you have commit access, I would think it’s fine to just go ahead and push it.

1 Like
13

Somehow patches which haven’t been merged can’t be accessed now, like https://reviews.llvm.org/D70401. Is this by design?
And, the phabricator has been a static archive now, how can I know the list of my unmerged patches? There is no personal profile now.

1 Like
14

Sounds like another instance of Some reviews on reviews.llvm.org seem to be missing from the static archive