How to commit a reviewed patch

Project Infrastructure Code Review
1

Hi All,

I have a patch that has been reviewed in phabricator: ⚙ D141909 Avoid removing useful loop metadata when striping debug info
Since I don’t have commit access, I commented in the patch as mentioned in the document.

Is there anything else I need to do? Or should I apply for commit access somehow?

Thanks,
Dongrui

2

Hi Dongrui,

You should ask someone to commit the patch on your behalf (e.g., one of the reviewers). Since you’ve already asked in the review thread, I’d personally recommend to directly message/email the reviewer(s). After a few patches submitted like this, you can apply for commit access. We have this described here: LLVM Developer Policy — LLVM 17.0.0git documentation.

1 Like