How to Rerun buildkite/github-pull-requests

Project Infrastructure GitHub
1

I pushed a commit to an existing PR and noticed that the buildkite/github-pull-requests job failed.

I have gotten the same error a few times since switching to GitHub on different PRs, and I do not believe that it is related to my changes. I only see the pr-recieve::pr-target job under the “Checks” tab of the PR. How do I re-run the buildkite/github-pull-requests job?

This is the relevant part of the logs that shows the error, although I’m not sure that this information is needed to help me figure out how to re-run the job:

MT: command "C:\Program Files (x86)\Windows Kits\10\bin\10.0.19041.0\x64\mt.exe /nologo /manifest unittests\Testing\Support\TestingSupportTests.exe.manifest /outputresource:unittests\Testing\Support\TestingSupportTests.exe;#1" failed (exit code 0x1f) with the following output:
mt.exe : general error c101008d: Failed to write the updated manifest to the resource of file "unittests\Testing\Support\TestingSupportTests.exe". Operation did not complete successfully because the file contains a virus or potentially unwanted software.
1 Like
2

Cc @goncharov

3

Hi @michaelmaitland !

  1. about the AV failure: I saw this issue a couple of times but have not figured what triggers that as defender should be off

  2. at the moment builds are initiated by buildkite so the only way to re-trigger is to push a new commit. Alternative would be to use Trigger Buildkite Pipeline · Actions · GitHub Marketplace · GitHub action to control it from GitHub. @tobiashieta @tstellar what do you think?

4

I think it would be nice to add trigger buildkite pipeline action in GitHub since the alternative creates unnecessary noise for reviewers.

5

I hit the same “general error c101008d” in Github pull requests #2622 (buildkite.com) triggered by [NFC][AsmPrinter] Refactor FrameIndexExprs as a std::set by slinder1 · Pull Request #66433 · llvm/llvm-project (github.com)

Is the best option still to push a new commit?

6

@slinder1 yes, I think so

7

Is there any update regarding retriggering the PR checks without updating the PR with new commits?

8

Hi! Not really any updates. I have tried previously to run checks on github actions and it works fine. Realistically I think we should look into migrating to github actions after phabricator is completely gone.

9

I found this good blog post about setting up self-hosted GitHub runners. I think it would make sense to try this out.

10

I have a github runner image https://github.com/google/llvm-premerge-checks/tree/main/containers/github-runner that I have successfully tested in my fork to trigger on pull requests https://github.com/metaflow/llvm-project/blob/7f745f792533754390056e8e3c95df57dd088b15/.github/workflows/pull-request.yml

With some additinal development we can definitely convert from buildkite → github actions (that would require some updates in libcxx etc but hopefully not too extreme). cc @ldionne

11

Were you running those jobs a host of your own or on Github’s provided host?

12

if I remember correctly that was done by running a docker from a localhost so I have assumed that we can convert buildkite runners to be github actions runners