It looks like a couple of bots are having issues after this patch;
they're getting ~270 test failures. I replied to the commit email
but got no response. The bots I'm seeing fail are:
clang-x64-ninja-win7 (stage 1)
My guess is they need to rerun cmake (& delete CMakeCache.txt first,
if not the entire build tree). That worked in my local builds.
I only saw your response to my change now, I apologize about the late response. I observed the same issue on clang-x86-windows-msvc2015 and sanitizer-windows. The problem is that these builders are only doing incremental build and the CMakeCache.txt contains the wrong triple now.
I resolved that by triggering a build through buildbot UI and setting the “clean: True” property which forced the clean build. Do you know if llvm-clang-x86_64-expensive-checks-win and clang-x64-ninja-win7 support that property as well? I can try triggering a build on those builders as well to see if it’s going to help.
Yes, it looks like those bots use the same UI so the same fix should work.