Phabricator not working for at least one review

Project Infrastructure Code Review
1

I can’t seem to access https://reviews.llvm.org/D149759. I get this error:

Argument 1 passed to idx() must be of the type array, null given, called in /srv/http/phabricator/src/applications/harbormaster/storage/build/HarbormasterBuildUnitMessage.php on line 158

I’ve tried a different review and it is working fine, so it’s not a blanket-wide Phabriactor issue.

2

Another review where this is happening is https://reviews.llvm.org/D158333

3

Same with https://reviews.llvm.org/D156609

4

CC @MaskRay

5

These differentials should start to work about 1 hour ago.

After I resized the disk to be 150GB larger, we quickly ran into a “full disk” situation on Sunday again (after just 2 days). Thanks to @jrtc27 for suggesting that it may be a quadratic complexity issue related to Phabricator importing GitHub commits (e.g. stray commit https://reviews.llvm.org/rG948a49a40139066f37591e36cf02b1cd17af5c29 I did not push a commit with this subject).

Login used to have a Fetch Refs setting of all refs/*. I changed the setting to Fetch Refs: refs/heads/*, refs/tags/* as @jrtc27 suggested.

To reclaim some disk space, I manually garbage-collected the harbormaster_buildunitmessage table (72570.98MiB, huge). It seems that null properties values are problematic.

Patching the line to return $this->properties ? idx($this->properties, $key, $default) : $default; works.

mysql> SELECT table_name AS "Table", ROUND(((data_length + index_length) / 1024 / 1024), 2) AS "Size (MB)" FROM information_schema.TABLES ORDER BY (data_length + index_length) DESC limit 40;
+------------------------------------+-----------+
| Table                              | Size (MB) |
+------------------------------------+-----------+
| differential_changeset_parse_cache | 443397.97 |
| harbormaster_buildunitmessage      |  72570.98 |
| differential_hunk                  |  40864.25 |
| repository_commit_fngrams          |  22533.25 |
| file_storageblob                   |  20005.89 |
| herald_transcript                  |  15506.17 |
| repository_pathchange              |  15124.92 |
| repository_path                    |   9103.95 |
| cache_general                      |   8648.73 |
| differential_revision_fngrams      |   8199.19 |
| repository_filesystem              |   4790.00 |
| repository_commit_ffield           |   4555.41 |
| differential_revision_ffield       |   3646.08 |
| differential_changeset             |   2542.58 |
| differential_transaction           |   2114.95 |
| paste_paste_fngrams                |   1800.63 |
| file_filename_ngrams               |   1641.42 |
| edge                               |   1458.88 |
| cache_markupcache                  |   1398.47 |
| repository_commitdata              |   1343.56 |
| differential_transaction_comment   |   1333.73 |
| metamta_mail                       |   1253.44 |
| repository_commit                  |   1130.22 |
| paste_paste_ffield                 |   1089.16 |
| conduit_methodcalllog              |    960.17 |
| audit_transaction                  |    930.53 |
| edge                               |    900.53 |
| edge                               |    891.36 |
| edge                               |    826.63 |
| feed_storydata                     |    731.56 |
| feed_storynotification             |    716.70 |
| file                               |    690.59 |
| metamta_receivedmail               |    662.58 |
| feed_storyreference                |    633.95 |
| search_indexversion                |    563.66 |
| repository_commit_fdocument        |    460.14 |
| harbormaster_buildtarget           |    436.23 |
| search_documentrelationship        |    419.38 |
| draft_versioneddraft               |    376.25 |
| edge                               |    359.83 |
+------------------------------------+-----------+
2 Likes