Recent cmake changes to libcxx

Clang Frontend
1

Hi

The recent cmake changes to libcxx are a bit __________.

It's been pushed and reverted like 3 times now. It broke our build
(which nobody will care about), but it would be really appreciated if
there was a cmake option to disable depending on the llvm sources in a
standalone build. I think Eric may already have a patch to achieve
this, but next time he pushes - can everyone just tough it out and
push bug fixes instread of the big revert hammer (he's pretty quick
when online).

Personally, I don't think this is the correct approach, but I
understand why he wants to do it. I'm hoping that by bringing
attention to this - others may be able to weigh in on their ideas.

Thanks

2

The recent cmake changes to libcxx are a bit __________.

Shitty? My apologies. I didn't fully understand the scope or
complexity of the changes.

it would be really appreciated if there was a cmake option to disable depending on the
llvm sources in a standalone build.

There will be no need for a CMake option. Failing to find LLVM source
tree will result in a warning, not an error.
However most of the build features, including the test suite, will
only be enabled when the LLVM sources
have been found. I was mistaken when I originally made LLVM a hard requirement.

/Eric

3

Sounds like a good plan to me.

cheers,
--renato