I've recently submitted a patch to llvm-commits (as requested by https://llvm.org/docs/DeveloperPolicy.html#making-and-submitting-a-patch) and the mailing list answered with a notice that my message is held for moderator approval (with the reason: "Post by non-member to a members-only list"). I'm therefore wondering if I should've submitted my patch via Phabricator instead (looking at the activity in llvm-commits, it seems that most of the patches are submitted and reviewed by Phabricator).
Hi,
The current practice is to upload a patch to phabricator and add llvm-commits as a subscriber. This will send an email to the mailing list. You can (and should) add some reviewers too.
Yup, Phabricator is generally preferred for patches.
Additionally, are you subscribed to the mailing list? I can’t find where I read it now, but I believe your messages are held for moderation if you aren’t subscribed. You can subscribe at http://lists.llvm.org/mailman/listinfo/llvm-commits if needed.
Date: Sat, 30 Dec 2017 09:59:56 -0600
From: Krzysztof Parzyszek via llvm-dev <llvm-dev@lists.llvm.org <mailto:llvm-dev@lists.llvm.org>>
To: llvm-dev@lists.llvm.org <mailto:llvm-dev@lists.llvm.org>
Subject: Re: [llvm-dev] Submitting patches for LLVM -- llvm-commits
vs. Phabricator?
Hi,
The current practice is to upload a patch to phabricator and add
llvm-commits as a subscriber. This will send an email to the mailing
list. You can (and should) add some reviewers too.
-Krzysztof
Yup, Phabricator is generally preferred for patches.
Additionally, are you subscribed to the mailing list? I can't find where I read it now, but I believe your messages are held for moderation if you aren't subscribed. You can subscribe at llvm-commits Info Page if needed.
Thanks guys! This is my first attempt to submit a patch; I've sent it to llvm-commits because the Developer Guide mentions this as preferred method:
Once your patch is ready, submit it by emailing it to the appropriate project’s commit mailing list (or commit it directly if applicable). Alternatively, some patches get sent to the project’s development list or component of the LLVM bug tracker, but the commit list is the primary place for reviews and should generally be preferred.
I guess this part should be updated then to mention Phabricator as the primary place for submitting and reviewing patches?
I'm subscribed to llvm-commits yes (in digest mode if that should make a difference), but the message was not submitted to the list (it seems to be still in the queue waiting for moderator approval). Anyhow, I will submit my little patch via Phabricator then and refer to the Phabricator docs for procedere and finding reviewers. Thanks!
Date: Sat, 30 Dec 2017 09:59:56 -0600
From: Krzysztof Parzyszek via llvm-dev <llvm-dev@lists.llvm.org <mailto:llvm-dev@lists.llvm.org>>
To: llvm-dev@lists.llvm.org <mailto:llvm-dev@lists.llvm.org>
Subject: Re: [llvm-dev] Submitting patches for LLVM -- llvm-commits
vs. Phabricator?
Hi,
The current practice is to upload a patch to phabricator and add
llvm-commits as a subscriber. This will send an email to the mailing
list. You can (and should) add some reviewers too.
-Krzysztof
Yup, Phabricator is generally preferred for patches.
Additionally, are you subscribed to the mailing list? I can't find where I read it now, but I believe your messages are held for moderation if you aren't subscribed. You can subscribe at llvm-commits Info Page if needed.
Thanks guys! This is my first attempt to submit a patch; I've sent it to llvm-commits because the Developer Guide mentions this as preferred method:
Once your patch is ready, submit it by emailing it to the appropriate project’s commit mailing list (or commit it directly if applicable). Alternatively, some patches get sent to the project’s development list or component of the LLVM bug tracker, but the commit list is the primary place for reviews and should generally be preferred.
I guess this part should be updated then to mention Phabricator as the primary place for submitting and reviewing patches?
Would you mind updating the section and uploading the patch to reviews.llvm.org ?
-- adrian
AFAIK, last time we discussed this, the consensus was that the llvm-commits mailing list is the authoritative place for patches and using phabricator (which then produces posts for the mailing list) is considered optional.
In practice of course there is only a handful of people posting to the mailing list directly without using phabricator, so I guess changing the docu is fine
?