How to submit a series of patches in a single review

Project Infrastructure LLVM Dev List Archives
1

Hi all,

I’m new for community contribution and I wonder is there a way to submit patch series in a single review?
For example I have 2 patches: A and B. B depends on A. How can I submit them together?

  1. The Web interface (Code Reviews with Phabricator — LLVM 16.0.0git documentation) seems doesn’t allow uploading multiple patches.
  2. I also tried the command line tool arc (Code Reviews with Phabricator — LLVM 16.0.0git documentation) by invoking arc diff HEAD~ on each commit.
    But these produce 2 seperate reviews and lose dependency.

Any advice?

Best regards,
Shaka

2

It's not automated, but what I do is upload them all then go to "Edit
related revisions" on the review page and link them together that way.
Then you should see a "Stack" in the "Revision contents" section.
(e.g. ⚙ D107140 [lldb] Add option to show memory tags in memory read output)

3

Hi Shaka,

I just taught someone else how to do this morning!

What I do first is option 2 to get 2 separate reviews, then navigate to
the web interface for 'B' and click "Edit Related Revisions" -> "Edit
Parent Revisions" -> <click A>.

This creates a patch "stack" which is what you're after.

I agree it's not very well documented: it took me a while to work out
what to do. Do people think we should add some documentation to this
effect?

Thanks,
Fraser

4

Sounds good! I will have a try. Thanks

------------------ Original ------------------

5

See Arcanist User Guide — Mozilla Conduit 0 documentation. There's a link to a blog post that explained this use-case very well. Sadly, that page is gone :frowning:

On 10/12/2021 11:39, Fraser Cormack via llvm-dev wrote:>> Do people think we should add some documentation to this> effect?
Yes, please :slight_smile: It's also worth asking on Discord and Discourse.

-Andrzej

6

Posted ⚙ D115519 [llvm][docs] Describe how to work with patch series on Phabricator. Quite minimal so other ideas
are welcome.

Shaka, I don't know if you are already registered on Phabricator but
it would be great to have you review this too when you are. After all,
it's only useful if it would have answered your question.

7

The new content is live at
https://llvm.org/docs/Phabricator.html#creating-a-patch-series

If you come back to this and anything is still unclear feel free to
let me know and I'll update it. And thanks for bringing it up, this
will be useful for a lot of people.

8

Thanks David. Sorry for the late response:(
The document is very clear to me. I’m totally agree with you this may help a lot of people especially new contributors.

------------------ Original ------------------

9

I like using the moz-phab tool, which handles this use case pretty well, I think.
https://moz-conduit.readthedocs.io/en/latest/phabricator-user.html#submitting-patches

Steve